refactor: Interpret all rpaths as resource names in transactions #318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a new addition to zizmor.
By running `uv lock --upgrade --refresh`.
Proof of concept for a single repo-and-branch-scoped transaction. This ties a transaction to a single repo and branch by taking all file and directory names by resource only instead of a full URI. Naturally, this has the subtle side effect that given full URIs are silently understood as nested paths, and uploaded to the transaction branch without loud errors or warnings. A section was added to the transaction docs that details this behavior, but it might be safer to check the input path against existing repos and branches.
nicholasjng
changed the title
|
An example that would be a silent failure case with this change: fs = LakeFSFileSystem()
with fs.transaction("my-repo", "my-branch"):
fs.put_file("hello.txt", "my-other-repo/my-other-branch/hello.txt") # <- creates the file my-repo/my-branch/my-other-repo/my-other-branch/hello.txt. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Built on #317.
Proof of concept for a single repo-and-branch-scoped transaction.
This ties a transaction to a single repo and branch by taking all file and
directory names by resource only instead of a full URI.
Naturally, this has the subtle side effect that given full URIs are silently
understood as nested paths, and uploaded to the transaction branch without
loud errors or warnings. A section was added to the transaction docs that
details this behavior, but it might be safer to check the input path against
existing repos and branches.
cc @AdrianoKF, after the UPathManager excursion we had lately. Opinions welcome - I'm leaning towards at least validating the input path against existing repos to make sure that the user doesn't accidentally do the wrong thing.
But in general, in my opinion, scoping transactions to a single repo and branch pair only makes sense, insofar as uploading resources to other repos and branches results in silent uncommitted changes, which is also not ideal.
Outstanding test failures are because I haven't ported all methods to the
make_uri(rpath)pattern yet - I'm not sure this is the most elegant way to do things, so if you have other ideas, please let me know.